Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] RAFT KITTI test cfg and set_env #165

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Fix] RAFT KITTI test cfg and set_env #165

wants to merge 2 commits into from

Conversation

MeowZheng
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

  1. Image norm arguments in kitti2015_raft_test.py don't suit raft.
  2. set_env supports model testing

Modification

  1. configs/base/datasets/kitti2015_raft_test.py
  2. mmflow/utils/set_env.py

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Jul 3, 2022

Codecov Report

Merging #165 (ae6b61a) into master (cf1c2f2) will decrease coverage by 0.47%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   69.03%   68.56%   -0.48%     
==========================================
  Files          92       92              
  Lines        5148     5153       +5     
  Branches      733      735       +2     
==========================================
- Hits         3554     3533      -21     
- Misses       1481     1505      +24     
- Partials      113      115       +2
Flag Coverage Δ
unittests 68.56% <33.33%> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmflow/utils/set_env.py 75.67% <33.33%> (-8.70%) ⬇️
mmflow/datasets/pipelines/transforms.py 77.50% <0.00%> (-3.67%) ⬇️
mmflow/datasets/dataset_wrappers.py 43.75% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf1c2f2...ae6b61a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MeowZheng